Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@kafka.apache.org
From: ijuma <git@git.apache.org>
To: dev@kafka.apache.org
Reply-To: dev@kafka.apache.org
Message-ID: <git-pr-2588-kafka@git.apache.org>
Subject: [GitHub] kafka pull request #2588: KAFKA-4788: Revert "KAFKA-4092: retention.bytes sh...
Content-Type: text/plain
Date: Thu, 23 Feb 2017 13:23:34 +0000 (UTC)
archived-at: Thu, 23 Feb 2017 13:23:37 -0000

GitHub user ijuma opened a pull request:

    https://github.com/apache/kafka/pull/2588

    KAFKA-4788: Revert "KAFKA-4092: retention.bytes should not be allowed to be less than segment.bytes"

    The intent is good, but it needs to take into account broker configs as well.
    See KAFKA-4788 for more details.
    
    This reverts commit 4ca5abe8ee7578f602fb7653cb8a09640607ea85.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijuma/kafka kafka-4788

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/2588.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2588
    
----
commit 56c197a904dbf7549534f6589e062c61e17e47b5
Author: Ismael Juma <ismael@juma.me.uk>
Date:   2017-02-23T13:19:06Z

    Revert "KAFKA-4092: retention.bytes should not be allowed to be less than segment.bytes"
    
    The intent is good, but it needs to take into account broker configs as well.
    See KAFKA-4788 for more details.
    
    This reverts commit 4ca5abe8ee7578f602fb7653cb8a09640607ea85.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---