kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From original-brownbear <...@git.apache.org>
Subject [GitHub] kafka pull request #2573: MINOR: Cleanup org.apache.kafka.streams.kstream.in...
Date Sun, 19 Feb 2017 07:36:17 GMT
GitHub user original-brownbear opened a pull request:

    https://github.com/apache/kafka/pull/2573

    MINOR: Cleanup org.apache.kafka.streams.kstream.internals.AbstractKTableKTableJoinValueGetterSupplier#storeNames
(performance and clarity)

    Just a trivial fix improving the performance and clarity of `org.apache.kafka.streams.kstream.internals.AbstractKTableKTableJoinValueGetterSupplier#storeNames`.
    
    The method is essentially just an array concatenation. This shouldn't be done via an `ArrayList`,
replaced it by direct instantiation + copy.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/original-brownbear/kafka cleanup-store-names

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/2573.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2573
    
----
commit 3f96418c685d66eee4266b3c221ef2ba6beb5fd0
Author: Armin Braun <me@obrown.io>
Date:   2017-02-19T07:30:44Z

    MINOR: Cleanup org.apache.kafka.streams.kstream.internals.AbstractKTableKTableJoinValueGetterSupplier#storeNames
(performance and clarity)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message