kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Lukavsk√Ĺ <je...@seznam.cz>
Subject Re: Live-lock between consumer thread and heartbeat thread
Date Thu, 02 Feb 2017 14:21:15 GMT
Hi Ismael,

short answer at the end of this email. :)

On 02/02/2017 02:52 PM, Ismael Juma wrote:

> I hadn't quite understood this. So the asynchronous code continues to
> update the map, I see.
>
> Regarding your suggested fix, the required change is not to hold a lock to
> the map passed to `commitSync`, so cloning should be enough to fix the
> issue. So do I understand correctly that moving the commitSync out the
> synchronized block is an optimisation (i.e. the async threads can update
> the map while the commitSync is happening)?
>

Yes, exactly.
Best,
  Jan

Mime
View raw message