Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@kafka.apache.org
Date: Tue, 17 Jan 2017 13:10:26 +0000 (UTC)
From: "Dhwani Katagade (JIRA)" <jira@apache.org>
To: dev@kafka.apache.org
Message-ID: <JIRA.13033672.1484130169000.27550.1484658626553@Atlassian.JIRA>
In-Reply-To: <JIRA.13033672.1484130169000@Atlassian.JIRA>
References: <JIRA.13033672.1484130169000@Atlassian.JIRA> <JIRA.13033672.1484130169737@jira-lw-us.apache.org>
Subject: [jira] [Commented] (KAFKA-4617) gradle-generated core eclipse
 project has incorrect source folder structure
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 17 Jan 2017 13:10:35 -0000


    [ https://issues.apache.org/jira/browse/KAFKA-4617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15826017#comment-15826017 ] 

Dhwani Katagade commented on KAFKA-4617:
----------------------------------------

[~ecomar] thanks for your comments.
I tried to remove the following explicit dependency from build.gradle but it is required by the scala plugin for building test classes. Without it the :core:compileTestScala task fails.

testCompile project(':clients').sourceSets.test.output

I had to fix the generated .classpath file in the whenMerged closure itself. I have pushed an additional commit with changes to handle this.
Please review.

> gradle-generated core eclipse project has incorrect source folder structure
> ---------------------------------------------------------------------------
>
>                 Key: KAFKA-4617
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4617
>             Project: Kafka
>          Issue Type: Bug
>          Components: build
>            Reporter: Edoardo Comar
>            Assignee: Dhwani Katagade
>            Priority: Minor
>              Labels: build
>
> The gradle-generated Eclipse Scala project for Kafka core has a 
> classpath defined as :
> {code:xml}
> 	<classpathentry kind="src" path="src/main/scala"/>
> 	<classpathentry kind="src" path="src/test/scala"/>
> 	<classpathentry kind="src" path="src/test/resources"/>
> {code}
> because of how the source files are for tests are structured, code navigation / running unit tests fails. The correct structure should be instead :
> {code:xml}
> 	<classpathentry kind="src" path="src/main/scala"/>
> 	<classpathentry excluding="integration/|other/|unit/" kind="src" path="src/test/scala"/>
> 	<classpathentry kind="src" path="src/test/scala/other"/>
> 	<classpathentry kind="src" path="src/test/scala/integration"/>
> 	<classpathentry kind="src" path="src/test/scala/unit"/>
> 	<classpathentry kind="src" path="src/test/resources"/>
> {code}
> Moreover, the classpath included as libraries core/build/test and core/build/resources
> which should not be there as the eclipse classes are not generated under build


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)