Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@kafka.apache.org
From: Eno Thereska <eno.thereska@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Mac OS X Mail 10.2 \(3259\))
Subject: Re: [DISCUSS] KIP-104: Granular Sensors for Streams
Date: Fri, 6 Jan 2017 23:31:36 +0000
References: <CAEhVOwFu=_e_0Qf6dmVuVM=o+R7VxHfnn_2UZsduy=DAh181dA@mail.gmail.com>
 <CAD5tkZaqnMxFtt3xQU=XFxeSWGPexy6=XT98ipgQ_aHmcR3zqQ@mail.gmail.com>
 <7F508D8F-5036-4DA2-98BB-536AE6DBE7A6@gmail.com>
 <CAD5tkZaoWCgetqU3q+i7ranhs38wM-u7fbR6nfdt0uEDYrgC-w@mail.gmail.com>
To: dev@kafka.apache.org
In-Reply-To: <CAD5tkZaoWCgetqU3q+i7ranhs38wM-u7fbR6nfdt0uEDYrgC-w@mail.gmail.com>
Message-Id: <295C5BFE-328B-4A01-A0E1-6F68527D8AB7@gmail.com>
archived-at: Fri, 06 Jan 2017 23:31:52 -0000

Thanks Guozhang, I adjusted the KIP to explicitly mention that we are =
exposing the Metrics object now as Ismael suggested, since it was lost =
in the details.

Eno
> On 6 Jan 2017, at 22:16, Ismael Juma <ismael@juma.me.uk> wrote:
>=20
> Thanks for the explanation Eno. The KIP did mention that the metrics
> registry would be exposed, yes. What is missing is that the registry =
is not
> currently exposed by anything else. Traditionally, we list all public =
APIs
> created by a KIP, which is effectively true for the registry in this =
case.
> Did we consider using an interface instead of the concrete class? It =
seems
> that a lot of these things were discussed in the PR, so it would be =
good to
> have a summary in the KIP too.
>=20
> Ismael
>=20
> On Fri, Jan 6, 2017 at 9:10 PM, Eno Thereska <eno.thereska@gmail.com> =
wrote:
>=20
>> So the KIP proposes exposing the metrics registry (second paragraph =
under
>> motivation). The community has indicated that they would like to 1. =
access
>> all the metrics and 2. register their own. We provide some helper
>> interfaces for them to register throughput and latency metrics, but
>> ultimately we felt it's best for them to have access to the full =
registry
>> as well. This is because application code is now intertwined with the
>> streams library and we don't want to limit the kinds of metrics they =
might
>> want to register, nor do we necessarily want to provide yet another =
wrapper
>> around Metrics.
>>=20
>> Thanks,
>> Eno
>>=20
>>> On 6 Jan 2017, at 20:34, Ismael Juma <ismael@juma.me.uk> wrote:
>>>=20
>>> Thanks for the KIP. Sounds useful. One thing that wasn't made clear =
is
>> that
>>> we are exposing `Metrics` as a public class for the first time. =
Neither
>> the
>>> consumer or producer expose it at the moment. Do we want to expose =
the
>>> whole class or would it be better to expose a more limited =
interface?
>>>=20
>>> Ismael
>>>=20
>>> On Sat, Dec 31, 2016 at 4:26 AM, Aarti Gupta <aartiguptaa@gmail.com>
>> wrote:
>>>=20
>>>> Hi all,
>>>>=20
>>>> I would like to start the discussion on KIP-104: Granular Sensors =
for
>>>> Streams
>>>> <https://cwiki.apache.org/confluence/display/KAFKA/KIP-
>>>> 104%3A+Granular+Sensors+for+Streams?src=3Dcontextnavchildmode>
>>>>=20
>>>> *https://cwiki.apache.org/confluence/pages/viewpage.
>> action?pageId=3D67636480
>>>> <https://cwiki.apache.org/confluence/pages/viewpage.
>> action?pageId=3D67636480
>>>>> *
>>>>=20
>>>> Looking forward to your feedback.
>>>>=20
>>>> Thanks,
>>>> Aarti and Eno
>>>>=20
>>=20
>>=20