kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From guozhangwang <...@git.apache.org>
Subject [GitHub] kafka pull request #2379: KAFKA-4633: Always using regex pattern subscriptio...
Date Sat, 14 Jan 2017 15:44:24 GMT
GitHub user guozhangwang opened a pull request:

    https://github.com/apache/kafka/pull/2379

    KAFKA-4633: Always using regex pattern subscription in StreamThread

    1. In StreamThread, always use subscribe(Pattern, ..) function in order to avoid sending
MetadataRequest with specific topic names and cause brokers to possibly auto-create subscribed
topics; the pattern is generated as "topic-1|topic-2..|topic-n".
    
    2. Minor cleanup: changed String[] to List<String> to avoid overloaded functions.
    
    3. Minor cleanup: augmented unit test error message and fixed a potential transient failure
in KafkaStreamTest.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/guozhangwang/kafka K4633-regex-pattern

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/2379.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2379
    
----
commit c571fd6fe33155ed355469997c5572b92ccdabab
Author: Guozhang Wang <wangguoz@gmail.com>
Date:   2017-01-14T08:17:37Z

    enforce always using regex pattern subscription

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message