kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dguy <...@git.apache.org>
Subject [GitHub] kafka pull request #2371: KAFKA-4588: Wait for topics to be created in Query...
Date Fri, 13 Jan 2017 18:11:17 GMT
GitHub user dguy opened a pull request:

    https://github.com/apache/kafka/pull/2371

    KAFKA-4588: Wait for topics to be created in QueryableStateIntegrationTest.shouldNotMakeStoreAvailableUntilAllStoresAvailable

    After debugging this i can see the times that it fails there is a race between when the
topic is actually created/ready on the broker and when the assignment happens. When it fails
`StreamPartitionAssignor.assign(..)` gets called with a `Cluster` with no topics. Hence the
test hangs as no tasks get assigned. To fix this I added a `waitForTopics` method to `EmbeddedKafkaCluster`.
This will wait until the topics have been created.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dguy/kafka integration-test-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/2371.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2371
    
----
commit 52f5792a41878a5decf26ad011178737096e0933
Author: Damian Guy <damian.guy@gmail.com>
Date:   2017-01-13T16:51:49Z

    metadata hack

commit c85facef85cfcfd25c7cae3560f4a098f0a97b92
Author: Damian Guy <damian.guy@gmail.com>
Date:   2017-01-13T18:07:48Z

    wait for topics to be created

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message