kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Edoardo Comar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-4617) gradle-generated core eclipse project has incorrect source folder structure
Date Tue, 17 Jan 2017 00:56:27 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-4617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15824788#comment-15824788

Edoardo Comar commented on KAFKA-4617:

[~dhwanikatagade] thanks for the patch, 

The source folders in core are now correct.
I see that you have made the eclipse compiled classes location match the ones used by gradle
on the CLI.
However two generated Eclipse projects (core and streams) still have a mistake.

Their generated classpaths still include as library entries the output directories of other
projects they depend on. They should not.

please see my comment in the PR 

> gradle-generated core eclipse project has incorrect source folder structure
> ---------------------------------------------------------------------------
>                 Key: KAFKA-4617
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4617
>             Project: Kafka
>          Issue Type: Bug
>          Components: build
>            Reporter: Edoardo Comar
>            Assignee: Dhwani Katagade
>            Priority: Minor
>              Labels: build
> The gradle-generated Eclipse Scala project for Kafka core has a 
> classpath defined as :
> {code:xml}
> 	<classpathentry kind="src" path="src/main/scala"/>
> 	<classpathentry kind="src" path="src/test/scala"/>
> 	<classpathentry kind="src" path="src/test/resources"/>
> {code}
> because of how the source files are for tests are structured, code navigation / running
unit tests fails. The correct structure should be instead :
> {code:xml}
> 	<classpathentry kind="src" path="src/main/scala"/>
> 	<classpathentry excluding="integration/|other/|unit/" kind="src" path="src/test/scala"/>
> 	<classpathentry kind="src" path="src/test/scala/other"/>
> 	<classpathentry kind="src" path="src/test/scala/integration"/>
> 	<classpathentry kind="src" path="src/test/scala/unit"/>
> 	<classpathentry kind="src" path="src/test/resources"/>
> {code}
> Moreover, the classpath included as libraries core/build/test and core/build/resources
> which should not be there as the eclipse classes are not generated under build

This message was sent by Atlassian JIRA

View raw message