Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A1911200BB7 for ; Wed, 9 Nov 2016 19:20:05 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id A05CA160AFA; Wed, 9 Nov 2016 18:20:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E915F160AEB for ; Wed, 9 Nov 2016 19:20:04 +0100 (CET) Received: (qmail 73760 invoked by uid 500); 9 Nov 2016 18:19:59 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 73745 invoked by uid 99); 9 Nov 2016 18:19:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Nov 2016 18:19:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id D8E402C1F56 for ; Wed, 9 Nov 2016 18:19:58 +0000 (UTC) Date: Wed, 9 Nov 2016 18:19:58 +0000 (UTC) From: "Ismael Juma (JIRA)" To: dev@kafka.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (KAFKA-4395) KafkaConfig and LogConfig should not have static initialization order dependencies MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 09 Nov 2016 18:20:05 -0000 [ https://issues.apache.org/jira/browse/KAFKA-4395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-4395: ------------------------------- Fix Version/s: 0.10.1.1 > KafkaConfig and LogConfig should not have static initialization order dependencies > ---------------------------------------------------------------------------------- > > Key: KAFKA-4395 > URL: https://issues.apache.org/jira/browse/KAFKA-4395 > Project: Kafka > Issue Type: Bug > Affects Versions: 0.10.0.1 > Reporter: Sumant Tambe > Assignee: Sumant Tambe > Fix For: 0.10.1.1 > > > LogConfig.configDef.serverDefaultConfigNames is not initialized properly in due to static initialization order dependencies between KafkaConfig and LogConfig. The map ends inserting null values, which are all string literals. Consider the following. > 1. KafkaConfig begins initialization at first because KafkaServer constructor needs KafkaConfig. > 2. at KafkaConfig.LogMessageFormatVersionProp it needs LogConfig. > 3. LogConfig begins initialization > 4. LogConfig.configDef begins initialization > 5. .define(UncleanLeaderElectionEnableProp....) needs KafkaConfig.UncleanLeaderElectionEnableProp, which is defined below KafkaConfig.LogMessageFormatVersionProp so it's null > 6. Can't start another initialization of KafkaConfig > 7. So .define inserts null. This is applicable to all three MinInSyncReplicasProp, UncleanLeaderElectionEnableProp, and CompressionTypeProp -- This message was sent by Atlassian JIRA (v6.3.4#6332)