kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ogirardot <...@git.apache.org>
Subject [GitHub] kafka pull request #2096: KAFKA-4372: Kafka Connect REST API does not handle...
Date Thu, 03 Nov 2016 13:59:02 GMT
GitHub user ogirardot opened a pull request:

    https://github.com/apache/kafka/pull/2096

    KAFKA-4372: Kafka Connect REST API does not handle DELETE of connector with slashes in
their names

    Kafka Connect REST API does not handle in many places connectors with slashes in their
names because it expects PathParams, this PR intends to : 
    * Reject as bad requests API calls trying to create connectors with slashes in their names
    * Add support for connector with slashes in their names in the DELETE part of the API
to allow users to cleanup their connectors without dropping everything.
    
    This PR adds as well the Unit Test needed for the creation part and was tested manually
for the DELETE part.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ogirardot/kafka fix/connectors-with-slashes-cannot-be-deleted

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/2096.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2096
    
----
commit cfdc2a9e50ae75bcaaa98cebf77b91c3fde963f3
Author: Olivier Girardot <o.girardot@lateral-thoughts.com>
Date:   2016-11-03T13:24:12Z

    Fix the delete kafka connectors REST API that did not accept slashes
    
    Even though the rest of the API points accept connector names containing slashes

commit eb08fbbca95ca9bdafc4058ada563b7d1615a721
Author: Olivier Girardot <o.girardot@lateral-thoughts.com>
Date:   2016-11-03T13:52:30Z

    Connectors should no longer have slashes in their names
    
    Added a BadRequestException if someone tries to create one like that
    and added unit test to check that

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message