kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jiangjie Qin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-4401) Change the KafkaServerTestHarness and IntegrationTestHarness from trait to abstract class.
Date Mon, 14 Nov 2016 21:19:58 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-4401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15665054#comment-15665054

Jiangjie Qin commented on KAFKA-4401:

[~ewencp] Interestingly, we have done the same thing as well for a few of our Java projects

I completely agree that it is important to reduce the time to run unit test and we should
avoid doing so in our own tests whenever possible. That said, I found it is handy for many
external projects to have the capability to run some simple functional test with in memory
Kafka setup. Otherwise they may have to write more costly and complicated system test. So
it seems useful for Kafka to provide the test harness tool to facilitate the external project
testing. But the external projects should use their own judgement to decide when to use the
test harness. For example, just like you mentioned, there are some tests that can be run relatively
quickly with the test harness in the Confluent schema registry while others may more suitable
for the system test.

> Change the KafkaServerTestHarness and IntegrationTestHarness from trait to abstract class.
> ------------------------------------------------------------------------------------------
>                 Key: KAFKA-4401
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4401
>             Project: Kafka
>          Issue Type: Task
>          Components: unit tests
>    Affects Versions:
>            Reporter: Jiangjie Qin
>            Assignee: Jiangjie Qin
>             Fix For:
> The IntegartionTestHarness and KafkaServerTestHarness are useful not only in Kafka unit
test, but also useful for the unit tests in other products that depend on Kafka.
> Currently there are two issues making those two test harness classes hard to use by other
Java users.
> 1. The two classes are Scala traits. This makes it difficult for people to write Java
unit test code. 
> 2. Some of the interfaces are Scala only. 
> It will be good to expose those two classes for more general usage and make them Java

This message was sent by Atlassian JIRA

View raw message