Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 92796200BC0 for ; Tue, 11 Oct 2016 02:22:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 90C89160AEB; Tue, 11 Oct 2016 00:22:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DCC9E160AF1 for ; Tue, 11 Oct 2016 02:22:21 +0200 (CEST) Received: (qmail 32258 invoked by uid 500); 11 Oct 2016 00:22:20 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 32168 invoked by uid 99); 11 Oct 2016 00:22:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Oct 2016 00:22:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 8BA622C0088 for ; Tue, 11 Oct 2016 00:22:20 +0000 (UTC) Date: Tue, 11 Oct 2016 00:22:20 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@kafka.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KAFKA-4289) CPU wasted on reflection calls initializing short-lived loggers MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 11 Oct 2016 00:22:22 -0000 [ https://issues.apache.org/jira/browse/KAFKA-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15563996#comment-15563996 ] ASF GitHub Bot commented on KAFKA-4289: --------------------------------------- GitHub user radai-rosenblatt opened a pull request: https://github.com/apache/kafka/pull/2006 KAFKA-4289 - moved short-lived loggers to companion objects Signed-off-by: radai-rosenblatt You can merge this pull request into a Git repository by running: $ git pull https://github.com/radai-rosenblatt/kafka omgsrsly Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/2006.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2006 ---- commit 7b475e6eaffab891b8737c00df71d951cc52c81b Author: radai-rosenblatt Date: 2016-10-11T00:21:07Z KAFKA-4289 - moved short-lived loggers to companion objects Signed-off-by: radai-rosenblatt ---- > CPU wasted on reflection calls initializing short-lived loggers > --------------------------------------------------------------- > > Key: KAFKA-4289 > URL: https://issues.apache.org/jira/browse/KAFKA-4289 > Project: Kafka > Issue Type: Bug > Affects Versions: 0.10.0.1 > Reporter: radai rosenblatt > > an internal profiling run at linkedin found ~5% of the CPU time consumed by `sun.reflect.Reflection.getCallerClass()`. > digging into the stack trace shows its from initializing short lived logger objects in `FileMessageSet` and `RequestChannel.Request` -- This message was sent by Atlassian JIRA (v6.3.4#6332)