kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ismael Juma (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (KAFKA-4326) Refactor LogCleaner to remove duplicate log copying logic
Date Fri, 28 Oct 2016 10:32:58 GMT

     [ https://issues.apache.org/jira/browse/KAFKA-4326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Ismael Juma resolved KAFKA-4326.
--------------------------------
       Resolution: Fixed
    Fix Version/s: 0.10.2.0

Issue resolved by pull request 2053
[https://github.com/apache/kafka/pull/2053]

> Refactor LogCleaner to remove duplicate log copying logic
> ---------------------------------------------------------
>
>                 Key: KAFKA-4326
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4326
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Jason Gustafson
>            Assignee: Jason Gustafson
>             Fix For: 0.10.2.0
>
>
> I think there's some code duplication in the log cleaner with respect to the copying
of the log and re-compression after cleaning. We have similar logic already in {{ByteBufferMessageSet}}
which we can potentially reuse. This improves encapsulation so that message format changes
in the future become a little easier (since they touch fewer components).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message