Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id AFD55200B6B for ; Fri, 9 Sep 2016 23:03:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id AE84E160AA3; Fri, 9 Sep 2016 21:03:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2A59B160ACE for ; Fri, 9 Sep 2016 23:03:22 +0200 (CEST) Received: (qmail 29108 invoked by uid 500); 9 Sep 2016 21:03:21 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 29011 invoked by uid 99); 9 Sep 2016 21:03:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Sep 2016 21:03:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id B17032C1B7B for ; Fri, 9 Sep 2016 21:03:20 +0000 (UTC) Date: Fri, 9 Sep 2016 21:03:20 +0000 (UTC) From: "Ismael Juma (JIRA)" To: dev@kafka.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KAFKA-4145) Avoid redundant integration testing in ProducerSendTests MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 09 Sep 2016 21:03:22 -0000 [ https://issues.apache.org/jira/browse/KAFKA-4145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15478241#comment-15478241 ] Ismael Juma commented on KAFKA-4145: ------------------------------------ I'd probably remove `testFlush`. The rest sounds good. > Avoid redundant integration testing in ProducerSendTests > -------------------------------------------------------- > > Key: KAFKA-4145 > URL: https://issues.apache.org/jira/browse/KAFKA-4145 > Project: Kafka > Issue Type: Improvement > Components: unit tests > Reporter: Jason Gustafson > Assignee: Vahid Hashemian > > We have a few test cases in {{BaseProducerSendTest}} which probably have little value being tested for both Plaintext and SSL. We can move them to {{PlaintextProducerSendTest}} and save a little bit on the build time. The following tests seem like possible candidates: > 1. testSendCompressedMessageWithCreateTime > 2. testSendNonCompressedMessageWithCreateTime > 3. testSendCompressedMessageWithLogAppendTime > 4. testSendNonCompressedMessageWithLogApendTime > 5. testAutoCreateTopic > 6. testFlush > 7. testSendWithInvalidCreateTime > 8. testCloseWithZeroTimeoutFromCallerThread > 9. testCloseWithZeroTimeoutFromSenderThread -- This message was sent by Atlassian JIRA (v6.3.4#6332)