Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B0E03200B8E for ; Mon, 26 Sep 2016 18:39:06 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id ADB5C160ACA; Mon, 26 Sep 2016 16:39:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id BFF3A160AC8 for ; Mon, 26 Sep 2016 18:39:05 +0200 (CEST) Received: (qmail 71402 invoked by uid 500); 26 Sep 2016 16:38:59 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 71386 invoked by uid 99); 26 Sep 2016 16:38:59 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Sep 2016 16:38:59 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 464ADC0C0D for ; Mon, 26 Sep 2016 16:38:59 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.998 X-Spam-Level: * X-Spam-Status: No, score=1.998 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=confluent-io.20150623.gappssmtp.com Received: from mx2-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id nvPTrrI3wRZJ for ; Mon, 26 Sep 2016 16:38:57 +0000 (UTC) Received: from mail-io0-f182.google.com (mail-io0-f182.google.com [209.85.223.182]) by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with ESMTPS id B0F935F365 for ; Mon, 26 Sep 2016 16:38:56 +0000 (UTC) Received: by mail-io0-f182.google.com with SMTP id r145so188225168ior.0 for ; Mon, 26 Sep 2016 09:38:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=confluent-io.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=LLVdm7uqK00bIi9q3EyjwgVSCox1No3CYxlzPkZ55f4=; b=aGtgZIDSX9oEsxsU3IGeiGm3vYjFrwvtu6+RVwICNU1dNXCG7w1FtVBjPPL7OvI7L6 dYQgXFRTbt9Ontfv0udrdmEjJpvz9fFGq9gZtZMBssGjn2yG4/TJsrgklQH6ZcbS6VlW N01vp0v5aoPfDn8ZoL99iq6oELt6AGEvPtTBMgqtN9uFszFNAuK902nI9hP+sWkz7cYu Ev/ponoihzOYwRb3VBvBLIKpvorZ+L5H1Er/s+CqsdvA5NkUM+Km/4GebmYqpgFK4sFa U7ILmdgj+W32cAHeCBNLP8nG+DWIFo25ojobaKp5tTeXU1qch+swXNgl8RI+BM3z6wbE IH4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=LLVdm7uqK00bIi9q3EyjwgVSCox1No3CYxlzPkZ55f4=; b=kmXpvfYGhGEz07SmsyGYatCpTApo7I9tVHji8qtOkzpz+AV3ZjGX4S5wzFOG/F0VOj 1yCgkb1bYm76ImWJgoNVaUzPgOXcUOkutmQwdHa62MWjMJMHOP3SbXK5097yD48GgTse YsVsc0tMC3+GAvMPdmSnHWg8FfB0Ndh7g6Qgh5K+nia/yMMxdy8R88xMML+eF7P2/Ter hXOwRQPwhdl5kfYGUus0DwxnLKxv4y98/w8AV16+/Ir6imoWJwERM8wMWjzc6qhjp/tr k6A4JykDVgaAdIdGzn+mtEap2SqL24SLbfmOFMteIrlRlpOCe/IenWrUqqOLjdeqerbT sRpQ== X-Gm-Message-State: AE9vXwNMtkEACGTHlYvtK3kFwzBSJO4y0kezX8yoTvZfv60Hji3Og2muEXgxgOW+LArjQzI8JVqlbNjGGBKr1mHZ X-Received: by 10.107.130.65 with SMTP id e62mr23200645iod.38.1474907935863; Mon, 26 Sep 2016 09:38:55 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.176.147 with HTTP; Mon, 26 Sep 2016 09:38:54 -0700 (PDT) In-Reply-To: <18896B53-5722-4462-87DC-6D78B46293FB@confluent.io> References: <17A87535-3781-4625-9D03-CA0096E5F884@confluent.io> <5525CE9E-741B-42A2-BE84-B5A3B3007A8B@confluent.io> <18896B53-5722-4462-87DC-6D78B46293FB@confluent.io> From: Jun Rao Date: Mon, 26 Sep 2016 09:38:54 -0700 Message-ID: Subject: Re: [DISCUSS] KIP-73: Replication Quotas To: "dev@kafka.apache.org" Content-Type: multipart/alternative; boundary=001a113ed2d0989d0b053d6bc355 archived-at: Mon, 26 Sep 2016 16:39:06 -0000 --001a113ed2d0989d0b053d6bc355 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Yes, this change makes sense to me since it gives the admin better control. Thanks, Jun On Sun, Sep 25, 2016 at 7:35 AM, Ben Stopford wrote: > Hi All > > We=E2=80=99ve made an adjustment to KIP-73: Replication Quotas which I=E2= =80=99d like to > open up to the community for approval. > > Previously the admin passed a list of replicas to be throttled: > > quota.replication.throttled.replicas =3D > [partId]:[replica],[partId]:[replica],[partId]:[replica] etc > > The change is to split this into two properties. One that corresponds to > the leader-side throttle, and the other that corresponds to the > follower-side throttle. > > quota.leader.replication.throttled.replicas =3D > [partId]:[replica],[partId]:[replica],[partId]:[replica] > quota.follower.replication.throttled.replicas =3D > [partId]:[replica],[partId]:[replica],[partId]:[replica] > > This provides more control over the throttling process. It also helps us > with a common use case which I=E2=80=99ve described below, for those inte= rested. > > Please reply if you have any comments / issues / suggestions. > > Thanks as ever. > > Ben > > > Sample Use Case: > > Say we are moving partition 0. It has replicas [104,107,109] moving to > [105,107,113] > > So the leader could be any of [104,107,109] and we know we will be > creating new replicas on 105 & 113. > > In the current mechanism, all we can do is apply both leader and follower > throttles to all 5: [104,107,109,105,113] which will mean the regular > replication traffic between (say 107 is leader) 107->104 and 107->109 wil= l > be throttled also. This is potentially problematic. > > What we really want to do is apply: > > LeaderThrottle [104,107,109] > FollowerThrottle [105,113] > > This way, during a rebalance, we that standard replication traffic will > not be throttled, but the rebalance will perform correctly if leaders > move. One subtlety is that, should the leader move to the =E2=80=9Cmove > destination=E2=80=9D node, it would no longer be throttled. But this is a= ctually to > our benefit in the normal case. > > --001a113ed2d0989d0b053d6bc355--