kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ismael Juma (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-4145) Avoid redundant integration testing in ProducerSendTests
Date Fri, 09 Sep 2016 21:03:20 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-4145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15478241#comment-15478241
] 

Ismael Juma commented on KAFKA-4145:
------------------------------------

I'd probably remove `testFlush`. The rest sounds good.

> Avoid redundant integration testing in ProducerSendTests
> --------------------------------------------------------
>
>                 Key: KAFKA-4145
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4145
>             Project: Kafka
>          Issue Type: Improvement
>          Components: unit tests
>            Reporter: Jason Gustafson
>            Assignee: Vahid Hashemian
>
> We have a few test cases in {{BaseProducerSendTest}} which probably have little value
being tested for both Plaintext and SSL. We can move them to {{PlaintextProducerSendTest}}
and save a little bit on the build time. The following tests seem like possible candidates:
> 1. testSendCompressedMessageWithCreateTime
> 2. testSendNonCompressedMessageWithCreateTime
> 3. testSendCompressedMessageWithLogAppendTime
> 4. testSendNonCompressedMessageWithLogApendTime
> 5. testAutoCreateTopic
> 6. testFlush
> 7. testSendWithInvalidCreateTime
> 8. testCloseWithZeroTimeoutFromCallerThread
> 9. testCloseWithZeroTimeoutFromSenderThread



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message