kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ryan P (JIRA)" <j...@apache.org>
Subject [jira] [Reopened] (KAFKA-3719) Pattern regex org.apache.kafka.common.utils.Utils.HOST_PORT_PATTERN is too narrow
Date Wed, 14 Sep 2016 19:26:20 GMT

     [ https://issues.apache.org/jira/browse/KAFKA-3719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Ryan P reopened KAFKA-3719:

I would like to re-open this topic for discussion. While [~gwenshap] is correct, underscores
are not valid hostnames per RFC-952 and RFC-1123. 

However they are still valid domain name characters per RFC-2181.

"The DNS itself places only one restriction on the particular labels
   that can be used to identify resource records.  That one restriction
   relates to the length of the label and the full name.  The length of
   any one label is limited to between 1 and 63 octets.  A full domain
   name is limited to 255 octets (including the separators).  The zero
   length full name is defined as representing the root of the DNS tree,
   and is typically written and displayed as ".".  Those restrictions
   aside, any binary string whatever can be used as the label of any
   resource record."

So while technically this underscores do violate the standard put in place for hostnames we
could stand to be a tad more lenient given the relaxed set of standards for use with domain
names. I personally feel that the flexibility in naming conventions outweighs the cost of
strict standards compliance. 


> Pattern regex org.apache.kafka.common.utils.Utils.HOST_PORT_PATTERN is too narrow
> ---------------------------------------------------------------------------------
>                 Key: KAFKA-3719
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3719
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Balazs Kossovics
>            Priority: Trivial
> In our continuous integration environment the Kafka brokers run on hosts containing underscores
in their names. The current regex splits incorrectly these names into host and port parts.
> I could submit a pull request if someone confirms that this is indeed a bug.

This message was sent by Atlassian JIRA

View raw message