kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guozhang Wang (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (KAFKA-4049) Transient failure in RegexSourceIntegrationTest.testRegexMatchesTopicsAWhenDeleted
Date Mon, 22 Aug 2016 23:10:21 GMT

     [ https://issues.apache.org/jira/browse/KAFKA-4049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Guozhang Wang resolved KAFKA-4049.
----------------------------------
       Resolution: Fixed
    Fix Version/s: 0.10.1.0

Issue resolved by pull request 1746
[https://github.com/apache/kafka/pull/1746]

> Transient failure in RegexSourceIntegrationTest.testRegexMatchesTopicsAWhenDeleted
> ----------------------------------------------------------------------------------
>
>                 Key: KAFKA-4049
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4049
>             Project: Kafka
>          Issue Type: Sub-task
>          Components: streams
>            Reporter: Guozhang Wang
>            Assignee: Guozhang Wang
>              Labels: test
>             Fix For: 0.10.1.0
>
>
> There is an hidden assumption in this test case that the created {{TEST-TOPIC-A}} and
{{TEST-TOPIC-B}} are propagated to the streams client at the same time, and stored as {{assignedTopicPartitions[0]}}.
However this is not always true since these two topics may be added on the client side as
two consecutive metadata refreshes.
> The proposed fix includes the following:
> 1. In {{waitForCondition}} do not trigger the {{conditionMet}} function again after the
while loop, but just remember the returned value from the last call. This is safer so that
if the condition changes after the while loop it will not be considered as well.
> 2. Not remembering a map of all the previous assigned partitions, but only the most recent
one. And also get rid of the final check after streams client is closed by just use {{equals}}
in the condition to make sure that it is exactly the same to the expected assignment.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message