kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ishita Mandhan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-3940) Log should check the return value of dir.mkdirs()
Date Tue, 12 Jul 2016 02:31:10 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15372078#comment-15372078
] 

Ishita Mandhan commented on KAFKA-3940:
---------------------------------------

If dir is changed from File to Files here https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/log/Log.scala#L78,
several functions will not be available for the type Files and alternative implementations
will need to be created for each of those calls. Is this what you meant or am I misunderstanding
something?

> Log should check the return value of dir.mkdirs()
> -------------------------------------------------
>
>                 Key: KAFKA-3940
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3940
>             Project: Kafka
>          Issue Type: Bug
>          Components: log
>    Affects Versions: 0.10.0.0
>            Reporter: Jun Rao
>            Assignee: Ishita Mandhan
>              Labels: newbie
>
> In Log.loadSegments(), we call dir.mkdirs() w/o checking the return value and just assume
the directory will exist after the call. However, if the directory can't be created (e.g.
due to no space), we will hit NullPointerException in the next statement, which will be confusing.
>    for(file <- dir.listFiles if file.isFile) {



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message