kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-3836) KStreamReduce and KTableReduce should not pass nulls to Deserializers
Date Mon, 04 Jul 2016 22:09:11 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15361797#comment-15361797
] 

ASF GitHub Bot commented on KAFKA-3836:
---------------------------------------

GitHub user jeyhunkarimov opened a pull request:

    https://github.com/apache/kafka/pull/1585

    KAFKA-3836: KStreamReduce and KTableReduce should not pass nulls to Deserializers

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jeyhunkarimov/kafka master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1585.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1585
    
----
commit 753b05d99e05b535d75caf69997eea0503682e42
Author: Jeyhun Karimov <je.karimov@gmail.com>
Date:   2016-07-04T21:58:28Z

    MINOR:KStreamReduce and KTableReduce should not pass nulls to Deserializers

----


> KStreamReduce and KTableReduce should not pass nulls to Deserializers
> ---------------------------------------------------------------------
>
>                 Key: KAFKA-3836
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3836
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams
>    Affects Versions: 0.10.0.0
>            Reporter: Avi Flax
>            Assignee: Jeyhun Karimov
>            Priority: Trivial
>              Labels: architecture
>
> As per [this discussion|http://mail-archives.apache.org/mod_mbox/kafka-users/201606.mbox/%3cCAHwHRrU29jw4jgVhSijWbVLZB3BC6Qz6pbH9TqCFBcoRJk4aZQ@mail.gmail.com%3e]
these classes currently pass null values along to Deserializers, so those Deserializers need
to handle null inputs and pass them through without throwing. It would be better for these
classes to simply not call the Deserializers in this case; this would reduce the burden of
implementers of {{Deserializer}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message