kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dguy <...@git.apache.org>
Subject [GitHub] kafka pull request #1570: KAFKA-3914: Global discovery of state stores
Date Wed, 29 Jun 2016 15:14:53 GMT
GitHub user dguy opened a pull request:

    https://github.com/apache/kafka/pull/1570

    KAFKA-3914: Global discovery of state stores

    @guozhangwang @enothereska please take a look. A few things that need to be clarified
    
    1. I've added `StreamsConfig.USER_ENDPOINT_CONFIG`, but should we have separate configs
for host and port or is this one config ok?
    2. `HostState` in the KIP has a `byte[]` field - not sure why and what it would be populated
with
    3. The API calls in the KIP all return `Map<HostState, Set<TaskMetadata>>`,
however i don't see why the  `Set` is required so I've changed it to `Map<HostState, TaskMetadata>`

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dguy/kafka kafka-3914

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1570.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1570
    
----
commit f22ca0e680063d42240d8ceebe140ecd9e3fab48
Author: Damian Guy <damian.guy@gmail.com>
Date:   2016-06-29T07:40:11Z

    Connect stateStores to source topics.
    Add user endpoint config to StreamsConfig.
    Collect Map<HostState, Set<TopicPartition>> in StreamPartitionAssignor
    API for retrieving Map<HostState, TaskMetadata>

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message