kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From iamnoah <...@git.apache.org>
Subject [GitHub] kafka pull request #1541: KAFKA-3892 prune metadata response to subscribed t...
Date Wed, 22 Jun 2016 20:24:54 GMT
GitHub user iamnoah opened a pull request:

    https://github.com/apache/kafka/pull/1541

    KAFKA-3892 prune metadata response to subscribed topics

    I believe this will cause clients to defensively prune their cluster metadata in all cases.
It doesn't address why a client without a Pattern subscription would receive a response containing
all topics and partitions for the cluster (which is still undesirable, but I am guessing would
require a fix for the broker.)
    
    In my own testing, this restored the amount of heap required to 0.8 consumer levels.
    
    I am concerned that I do not 100% understand all the uses of this class. My assumption
is that only topics that have been added are expected in the response and that the two unit
test modifications I needed to make were oversights.
    
    I am also assuming that this behavior was only applied to the pattern matching case to
avoid a small amount of (presumed) unnecessary work and not for correctness reasons.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/spredfast/kafka-1 remove-extra-metadata

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1541.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1541
    
----
commit cb19feac9c1473e8406fd10a895a41468373ddae
Author: Noah Sloan <nsloan@spredfast.com>
Date:   2016-06-22T20:10:35Z

    KAFKA-3892 prune metadata response to subscribed topics

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message