kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jklukas <...@git.apache.org>
Subject [GitHub] kafka pull request #1479: KAFKA-3711: Ensure a RecordingMap is passed to con...
Date Tue, 07 Jun 2016 16:03:35 GMT
GitHub user jklukas opened a pull request:

    https://github.com/apache/kafka/pull/1479

    KAFKA-3711: Ensure a RecordingMap is passed to configured instances

    See https://issues.apache.org/jira/browse/KAFKA-3711
    
    I've tested locally that this change does indeed resolve the warning I mention in the
ticket:
    ```
    org.apache.kafka.clients.consumer.ConsumerConfig: The configuration metric.dropwizard.registry
= kafka-metrics was supplied but isn't a known config.
    ```
    where `metric.dropwizard.registry` is a configuration value defined in a custom `MetricReporter`
(https://github.com/SimpleFinance/kafka-dropwizard-reporter).
    
    With this change, the above warning no longer appears, as @ewencp predicted.
    
    This contribution is my original work and I license the work to the project under the
project's open source license.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jklukas/kafka abstractconfig-originals

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1479.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1479
    
----
commit 5c7a41b3116bb65db3cc0ca5cb90521766d41fcb
Author: Jeff Klukas <jeff@klukas.net>
Date:   2016-06-07T14:33:32Z

    Ensure a RecordingMap is passed to configured instances

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message