kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-3740) Add configs for RocksDBStores
Date Sat, 25 Jun 2016 20:25:37 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-3740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15349772#comment-15349772
] 

ASF GitHub Bot commented on KAFKA-3740:
---------------------------------------

GitHub user HenryCaiHaiying opened a pull request:

    https://github.com/apache/kafka/pull/1553

    KAFKA-3740: Add configs for RocksDBStore

    This is the part I of the work to add the StreamsConfig to ProcessorContext.
    
    We need to access StreamsConfig in the ProcessorContext so other components (e.g. RocksDBWindowStore
or LRUCache can retrieve config parameter from application)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/HenryCaiHaiying/kafka config

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1553.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1553
    
----
commit 12973c2d090268db416417b18dfbbe3d96f6a9d5
Author: Henry Cai <hcai@pinterest.com>
Date:   2016-06-25T20:19:42Z

    KAFKA-3740: Add configs for RocksDBStore
    
    This is the part I of the work to add the StreamsConfig to ProcessorContext.
    
    We need to access StreamsConfig in the ProcessorContext so other components (e.g. RocksDBWindowStore
or LRUCache can retrieve config parameter from application)

----


> Add configs for RocksDBStores
> -----------------------------
>
>                 Key: KAFKA-3740
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3740
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams
>            Reporter: Guozhang Wang
>            Assignee: Henry Cai
>              Labels: api, newbie
>
> Today most of the rocksDB configs are hard written inside {{RocksDBStore}}, or the default
values are directly used. We need to make them configurable for advanced users. For example,
some default values may not work perfectly for some scenarios: https://github.com/HenryCaiHaiying/kafka/commit/ccc4e25b110cd33eea47b40a2f6bf17ba0924576

> One way of doing that is to introduce a "RocksDBStoreConfigs" objects similar to "StreamsConfig",
which defines all related rocksDB options configs, that can be passed as key-value pairs to
"StreamsConfig".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message