kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vahidhashemian <...@git.apache.org>
Subject [GitHub] kafka pull request: KAFKA-3664: Commit offset of unsubscribed part...
Date Thu, 19 May 2016 18:10:41 GMT
GitHub user vahidhashemian reopened a pull request:

    https://github.com/apache/kafka/pull/1363

    KAFKA-3664: Commit offset of unsubscribed partitions of the new consumer on a subscription
change

    When users are using group management, if they call consumer.subscribe() to change the
subscription, the removed subscriptions will be immediately removed and their offset will
not be committed.
    Also the revoked partitions passed to the ConsumerRebalanceListener.onPartitionsRevoked()
will not include those partitions.
    
    This pull request fixes this issue by following the design suggested by @becketqin [here](https://issues.apache.org/jira/browse/KAFKA-3664?focusedCommentId=15274470&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15274470).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vahidhashemian/kafka KAFKA-3664

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1363.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1363
    
----
commit 68e6b5507e6c587b035655c5c010bef5c282c7f7
Author: Vahid Hashemian <vahidhashemian@us.ibm.com>
Date:   2016-05-13T00:23:27Z

    KAFKA-3664: Commit offset of unsubscribed partitions of the new consumer on a subscription
change
    
    When users are using group management, if they call consumer.subscribe() to change the
subscription, the removed subscriptions are immediately removed and their offset are not committed.
    This pull request fixes this issue.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message