Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@kafka.apache.org
Date: Mon, 4 Apr 2016 05:42:25 +0000 (UTC)
From: "Guozhang Wang (JIRA)" <jira@apache.org>
To: dev@kafka.apache.org
Message-ID: <JIRA.12955366.1459532184000.123265.1459748545460@Atlassian.JIRA>
In-Reply-To: <JIRA.12955366.1459532184000@Atlassian.JIRA>
References: <JIRA.12955366.1459532184000@Atlassian.JIRA>
 <JIRA.12955366.1459532184705@arcas>
Subject: [jira] [Commented] (KAFKA-3491) Issue with consumer close() in
 finally block with 'enable.auto.commit=true'
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/KAFKA-3491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15223685#comment-15223685 ] 

Guozhang Wang commented on KAFKA-3491:
--------------------------------------

"if it's actually a good feature to provide": what feature are you referring to?

> Issue with consumer close() in finally block with 'enable.auto.commit=true'
> ---------------------------------------------------------------------------
>
>                 Key: KAFKA-3491
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3491
>             Project: Kafka
>          Issue Type: Bug
>          Components: consumer
>    Affects Versions: 0.9.0.0, 0.9.0.1
>            Reporter: dan norwood
>            Assignee: Jason Gustafson
>            Priority: Minor
>
> imagine you have a run loop that looks like the following:
> {code:java}
>   public void run() {
>     try {
>       consumer.subscribe(topics);
>       while (true) {
>         ConsumerRecords<K, V> records = consumer.poll(Long.MAX_VALUE);
>         records.forEach(record -> process(record));
>       }
>     } catch (WakeupException e) {
>       // ignore, we're closing
>     } catch (Exception e) {
>       log.error("Unexpected error", e);
>     } finally {
>       consumer.close();
>     }
>   }
> {code}
> if you run this with 'enable.auto.commit=true' and throw an exception in the 'process()' method you will still try to commit all the read, but unprocessed, offsets in the most recent batch.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)