Return-Path: X-Original-To: apmail-kafka-dev-archive@www.apache.org Delivered-To: apmail-kafka-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E758717CD9 for ; Tue, 6 Oct 2015 22:28:27 +0000 (UTC) Received: (qmail 44156 invoked by uid 500); 6 Oct 2015 22:28:27 -0000 Delivered-To: apmail-kafka-dev-archive@kafka.apache.org Received: (qmail 44057 invoked by uid 500); 6 Oct 2015 22:28:27 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 44040 invoked by uid 99); 6 Oct 2015 22:28:27 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Oct 2015 22:28:27 +0000 Date: Tue, 6 Oct 2015 22:28:26 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@kafka.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KAFKA-2474) Add caching for converted Copycat schemas in JSONConverter MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KAFKA-2474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14945936#comment-14945936 ] ASF GitHub Bot commented on KAFKA-2474: --------------------------------------- Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/250 > Add caching for converted Copycat schemas in JSONConverter > ---------------------------------------------------------- > > Key: KAFKA-2474 > URL: https://issues.apache.org/jira/browse/KAFKA-2474 > Project: Kafka > Issue Type: Sub-task > Components: copycat > Reporter: Ewen Cheslack-Postava > Assignee: Ewen Cheslack-Postava > Fix For: 0.9.0.0 > > > From discussion of KAFKA-2367: > bq. Caching of conversion of schemas. In the JSON implementation we're including, we're probably being pretty wasteful right now since every record has to translate both the schema and data to JSON. We should definitely be doing some caching here. I think an LRU using an IdentityHashMap should be fine. However, this does assume that connectors are good about reusing schemas (defining them up front, or if they are dynamic they should have their own cache of schemas and be able to detect when they can be reused). -- This message was sent by Atlassian JIRA (v6.3.4#6332)