kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From SinghAsDev <...@git.apache.org>
Subject [GitHub] kafka pull request: MINOR: Remove unreachable if check
Date Sat, 31 Oct 2015 00:07:50 GMT
GitHub user SinghAsDev opened a pull request:

    https://github.com/apache/kafka/pull/396

    MINOR: Remove unreachable if check

    @gwenshap @granders could you guys take a look at this trivial change. This piece makes
one think that for SSL, not passing `new_consumer=True` should be fine. It was fine until
recently.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/SinghAsDev/kafka MinorTestChange

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/396.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #396
    
----
commit 7d7c9d339e6e98e73610c339960c55e42987c9c9
Author: Ashish Singh <asingh@cloudera.com>
Date:   2015-10-31T00:05:00Z

    MINOR: Remove unreachable if check

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message