kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ijuma <...@git.apache.org>
Subject [GitHub] kafka pull request: KAFKA-2640; Remove `completeAll` and improve t...
Date Fri, 02 Oct 2015 09:31:25 GMT
GitHub user ijuma opened a pull request:


    KAFKA-2640; Remove `completeAll` and improve timeout passed to `Selector.poll` from `NetworkClient.poll`


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijuma/kafka kafka-2640-remove-complete-all-poll-timeout

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #272
commit 76b6d12c9c60954b58ed1cb0bc12dfbca1c6c0d8
Author: Ismael Juma <ismael@juma.me.uk>
Date:   2015-10-02T08:51:26Z

    Remove unused `NetworkClient.completeAll` methods
    They block indefinitely which is an anti-pattern.

commit 78bbfaafe83158c913a1828ac9a940dfb3d44383
Author: Ismael Juma <ismael@juma.me.uk>
Date:   2015-10-02T08:56:42Z

    `NetworkClient.poll` should not call `Selector.poll` with a value higher than `requestTimeoutMs`

commit 1c2e6ed2bf324538dc5ada9893cb3d43cda97ee6
Author: Ismael Juma <ismael@juma.me.uk>
Date:   2015-10-02T08:57:19Z

    Disallow `Selector.poll(-1)` as it's not something we do or want to do


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message