kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-2632) Move fetchable check from fetchedRecords to fetch response handler
Date Sun, 11 Oct 2015 06:38:06 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-2632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14952176#comment-14952176
] 

ASF GitHub Bot commented on KAFKA-2632:
---------------------------------------

GitHub user guozhangwang opened a pull request:

    https://github.com/apache/kafka/pull/295

    KAFKA-2632: move fetchable check ahead in handleFetchResponse

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/guozhangwang/kafka K2632

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/295.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #295
    
----
commit 6ef55eeb2363b46e99d8630121c8772b4193234a
Author: Guozhang Wang <wangguoz@gmail.com>
Date:   2015-10-11T06:41:18Z

    KAFKA-2632.v1

----


> Move fetchable check from fetchedRecords to fetch response handler
> ------------------------------------------------------------------
>
>                 Key: KAFKA-2632
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2632
>             Project: Kafka
>          Issue Type: Sub-task
>          Components: consumer
>            Reporter: Guozhang Wang
>            Assignee: Guozhang Wang
>             Fix For: 0.9.0.0
>
>
> Since we check if the partition is fetchable or not in fetchedRecords(), there is a bug
when the partition is paused during there is in-flight fetch request, it will not be ignored
in fetch response handler but after that, in fetchedRecords(), causing the fetcher to update
the fetched position already; later no fetch requests will ever be sent to the broker for
this partition since consumed != fetched.
> The proposed fix is to move this check from fetchedRecords to handleFetchResponse in
Fetcher.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message