kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ismael Juma (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-2620) Introduce Scalariform
Date Wed, 07 Oct 2015 19:22:26 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-2620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14947425#comment-14947425
] 

Ismael Juma commented on KAFKA-2620:
------------------------------------

I was thinking we'd use Scalastyle (KAFKA-2423). The issue is that introducing rules means
fixing the formatting which will cause a lot of merge pain. So, my thinking was to do it once
all the big 0.9.0.0 features are in.

> Introduce Scalariform
> ---------------------
>
>                 Key: KAFKA-2620
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2620
>             Project: Kafka
>          Issue Type: Bug
>          Components: build
>            Reporter: Grant Henke
>            Assignee: Grant Henke
>
> Many of our reviews include nit comments related to Scala style. Adding [Scalariform|https://github.com/daniel-trinh/scalariform]
allows us to reformat the code based on configurable standards at build time, ensuring uniform
readability and a short review/commit cycle. 
> I expect this will have some discussion around the rules we would like to include, and
if we actually want to adopt this. I will submit a sample patch to start the discussion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message