Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@kafka.apache.org
Date: Fri, 28 Aug 2015 02:43:45 +0000 (UTC)
From: "Ewen Cheslack-Postava (JIRA)" <jira@apache.org>
To: dev@kafka.apache.org
Message-ID: <JIRA.12859764.1440720573000.190324.1440729825816@Atlassian.JIRA>
In-Reply-To: <JIRA.12859764.1440720573000@Atlassian.JIRA>
References: <JIRA.12859764.1440720573000@Atlassian.JIRA>
 <JIRA.12859764.1440720573738@arcas>
Subject: [jira] [Commented] (KAFKA-2485) Allow producer performance to take
 properties from a file via --consumer.config command line parameter
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/KAFKA-2485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14717952#comment-14717952 ] 

Ewen Cheslack-Postava commented on KAFKA-2485:
----------------------------------------------

[~lindong] This looks good and is a nice improvement -- should help with customizing performance tests for the producer. Should we be adding the same to the Java producer performance class? I'm not sure what the future of the two classes is going to be since we now have two of them.

Also, fixing the title since "Allow producer performance to take properties from a file via --consumer.config command line parameter" really threw me since producers should not be configured via a consumer option :)

> Allow producer performance to take properties from a file via --consumer.config command line parameter
> ------------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-2485
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2485
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Dong Lin
>            Assignee: Dong Lin
>
> In order to allow ProducerPerformance to produce via ssl connection, we need the following (example) configuration:
> security.protocol=SSL
> ssl.protocol=TLS
> ssl.truststore.type=JKS
> ssl.truststore.location=serverkeystore.jks
> ssl.truststore.password=password
> ssl.keymanager.algorithm=SunX509
> ssl.trustmanager.algorithm=SunX509
> There are two ways to achieve it: 1) extend ProducerPerformance to explicitly accept all 7 ssl-related parameters; 2) allow ProducerPerformance to take properties from a file via --consumer.config command line parameter.
> It seems option 2) is better, because it requires less code, allows new options to be easily added in the future, and doesn't require user to specify password in the command line.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)