Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@kafka.apache.org
Date: Tue, 4 Aug 2015 00:22:04 +0000 (UTC)
From: "Ismael Juma (JIRA)" <jira@apache.org>
To: dev@kafka.apache.org
Message-ID: <JIRA.12838821.1434639122000.362056.1438647724796@Atlassian.JIRA>
In-Reply-To: <JIRA.12838821.1434639122000@Atlassian.JIRA>
References: <JIRA.12838821.1434639122000@Atlassian.JIRA>
 <JIRA.12838821.1434639122493@arcas>
Subject: [jira] [Commented] (KAFKA-2285) Logging trait obfuscates call site
 information
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/KAFKA-2285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652841#comment-14652841 ] 

Ismael Juma commented on KAFKA-2285:
------------------------------------

Better than a macro would be using @inline, but sadly that doesn't work for trait methods:

https://issues.scala-lang.org/browse/SI-4767

We could have a logger class instead, but that's a bigger change.

> Logging trait obfuscates call site information
> ----------------------------------------------
>
>                 Key: KAFKA-2285
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2285
>             Project: Kafka
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 0.8.2.0
>            Reporter: E. Sammer
>            Assignee: Grant Henke
>
> Using a logging trait, as many components in the codebase do, destroys call site information in logging message making debugging certain kinds of failures annoying in production systems. Most messages end up look like:
> {code}
> 2015-06-18 07:41:11,550 (kafka-request-handler-0) [WARN - kafka.utils.Logging$class.warn(Logging.scala:83)] Partition [events,1] on broker 1: No checkpointed highwatermark is found for partition [events,1]
> {code}
> I think the mental overhead of issuing the standard incantation of {{private static final Logger logger = LoggerFactory.get(Foo.class)}} (or the even shorter Scala equivalent) for each class is outweighed by the operational overhead of mapping strings back to their original call sites. This is an easy win improve the traceability of complex failures in production deployments.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)