kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-2411) remove usage of BlockingChannel in the broker
Date Fri, 28 Aug 2015 23:45:46 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-2411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14720799#comment-14720799

ASF GitHub Bot commented on KAFKA-2411:

GitHub user ijuma reopened a pull request:


    KAFKA-2411; remove usage of blocking channel


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijuma/kafka kafka-2411-remove-usage-of-blocking-channel

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #151
commit dbcde7e828a250708752866c4610298773dea006
Author: Ismael Juma <ismael@juma.me.uk>
Date:   2015-08-19T13:30:35Z

    Introduce `ChannelBuilders.create` and use it in `ClientUtils` and `SocketServer`

commit 6de8b9b18c6bfb67e72a4fccc10768dff15098f8
Author: Ismael Juma <ismael@juma.me.uk>
Date:   2015-08-19T14:22:55Z

    Use `Selector` instead of `BlockingChannel` for controlled shutdown

commit da7a980887ab2b5d007ddf80c3059b6619d52f99
Author: Ismael Juma <ismael@juma.me.uk>
Date:   2015-08-19T14:23:11Z

    Use `Selector` instead of `BlockingChannel` in `ControllerChannelManager`

commit 2b258901929e24fce2329bc85e650e4ca022bca0
Author: Ismael Juma <ismael@juma.me.uk>
Date:   2015-08-20T11:10:53Z

    Move `readCompletely` from `NetworkReceive` to `BlockingChannel`
    It is now a private method since it's not used anywhere else and it's
    been changed slightly to match the use-case better.

commit f804f633d93d2beea94017bba9225504c2f9cea4
Author: Ismael Juma <ismael@juma.me.uk>
Date:   2015-08-20T12:29:55Z

    Adjust buffer and max request size to match `BlockingChannel` behaviour
    Based on feedback from Gwen.

commit c71aab9b6e4c6172615a125d2406ff6f3d668996
Author: Ismael Juma <ismael@juma.me.uk>
Date:   2015-08-20T12:53:39Z

    Introduce specific methods in `SelectorUtils` and make the generic ones private
    As suggested by Gwen.

commit 1de16166232e0b9a4b0798de493869d3ce23964c
Author: Ismael Juma <ismael@juma.me.uk>
Date:   2015-08-20T13:17:45Z

    Reuse `Selector` when removing and re-adding brokers in `ControllerChannelManager`
    As suggested by Gwen.

commit bf5b9c81fa59efa2429a409d3872f4f6f0d5d589
Author: Ismael Juma <ismael@juma.me.uk>
Date:   2015-08-20T14:55:03Z

    Merge remote-tracking branch 'apache/trunk' into kafka-2411-remove-usage-of-blocking-channel
    * apache/trunk:
      KAFKA-2330: Vagrantfile sets global configs instead of per-provider override configs;
patched by Ewen Cheslack-Postava, reviewed by Geoff Anderson and Gwen Shapira
      KAFKA-2246; Fix incorrect config ZK path.
      KAFKA-2084; trivial follow-up (remove JUnit3Suite dependency)

commit 6712f24863ee55effd2ad033e0d086e3133cee7c
Author: Ismael Juma <ismael@juma.me.uk>
Date:   2015-08-21T00:12:38Z

    Merge remote-tracking branch 'apache/trunk' into kafka-2411-remove-usage-of-blocking-channel
    * apache/trunk:
      KAFKA-1901; Move Kafka version to be generated in code by build (instead of in manifest);
reviewed by Ismael Juma, Joel Koshy, Jason Rosenberg
      KAFKA-2015: Enable ConsoleConsumer to use new consumer

commit c20a52c320f3652f672f60d7b86f38643a1ebf93
Author: Ismael Juma <ismael@juma.me.uk>
Date:   2015-08-21T10:17:15Z

    Handle disconnections in `SelectorUtils`
    As suggested by Jun.

commit 80f4d5acd977a454a67d6866f4d3f66444015132
Author: Ismael Juma <ismael@juma.me.uk>
Date:   2015-08-21T11:15:14Z

    Add broker id tag to `metricTags` passed to `Selector`
    As suggested by Jun

commit 9d1614400f7481d6922dda1bdc6af36dfabb8be8
Author: Ismael Juma <ismael@juma.me.uk>
Date:   2015-08-24T09:05:19Z

    Merge remote-tracking branch 'apache/trunk' into kafka-2411-remove-usage-of-blocking-channel
    * apache/trunk:
      KAFKA-2439; Add MirrorMaker service class for system tests
      KAFKA-2457; Fix how the argument is passed to `compileScala`
      KAFKA-2457; StackOverflowError during builds

commit 5e81ab02cdf9b9d33fdd43fd6ddbb574b18eaa68
Author: Ismael Juma <ismael@juma.me.uk>
Date:   2015-08-24T14:46:36Z

    Make metadata updates optional in `NetworkClient`

commit 179bb65fed014c9799c912b106765ecd4ff28930
Author: Ismael Juma <ismael@juma.me.uk>
Date:   2015-08-27T08:07:00Z

    Merge remote-tracking branch 'apache/trunk' into wip/kafka-2411-remove-usage-of-blocking-channel
    * apache/trunk:
      KAFKA-2467: Fix changes to behavior in ConsoleConsumer: properly parse consumer.config
option, handle exceptions during message processing, and print number of processed messages
to stderr.
      KAFKA-2388: refactor KafkaConsumer subscribe API
      KAFKA-2072: Add StopReplica request/response to o.a.k.common.requests
      KAFKA-1683; persisting session information in Requests
      KAFKA-2136; Add throttle time (on quota violation) in fetch/produce responses; reviewed
by Joel Koshy, Dong Lin and Jun Rao
      KAFKA-2351; Catch all exceptions in socket server's acceptor; reviewed by Grant Henke,
Joel Koshy, Jiangjie Qin, Jun Rao

commit be00ca1bdc1dc2d79084fe5fd8cb1cb0008c9a7f
Author: Ismael Juma <ismael@juma.me.uk>
Date:   2015-08-26T10:53:40Z

    Add support for `ControlledShutdown` in `Protocol`

commit d22965d011ac33e25875f96b78c35a24fc1886bc
Author: Ismael Juma <ismael@juma.me.uk>
Date:   2015-08-27T10:38:13Z

    Use `NetworkClient` instead of `Selector` for controlled shutdown

commit c03bb729dd3cf09e36e90134034c1d281211e52c
Author: Ismael Juma <ismael@juma.me.uk>
Date:   2015-08-28T18:41:39Z

    Add support for `UpdateMetadata` and `LeaderAndIsr` in `Protocol`

commit 3eb6a3f1889acaadd0e6ea728e179e1659c05225
Author: Ismael Juma <ismael@juma.me.uk>
Date:   2015-08-28T18:45:22Z

    Use `NetworkClient` instead of `Selector` for controller/broker communication


> remove usage of BlockingChannel in the broker
> ---------------------------------------------
>                 Key: KAFKA-2411
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2411
>             Project: Kafka
>          Issue Type: Sub-task
>          Components: security
>            Reporter: Jun Rao
>            Assignee: Ismael Juma
>             Fix For: 0.8.3
> In KAFKA-1690, we are adding the SSL support at Selector. However, there are still a
few places where we use BlockingChannel for inter-broker communication. We need to replace
those usage with Selector/NetworkClient to enable inter-broker communication over SSL. Specially,
BlockingChannel is currently used in the following places.
> 1. ControllerChannelManager: for the controller to propagate metadata to the brokers.
> 2. KafkaServer: for the broker to send controlled shutdown request to the controller.
> 3. -AbstractFetcherThread: for the follower to fetch data from the leader (through SimpleConsumer)-
moved to KAFKA-2440

This message was sent by Atlassian JIRA

View raw message