kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guozhang Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-2384) Override commit message title in kafka-merge-pr.py
Date Mon, 03 Aug 2015 20:52:05 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-2384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652498#comment-14652498
] 

Guozhang Wang commented on KAFKA-2384:
--------------------------------------

[~ijuma] There seems some unicode encoding error with Python 2.x with this patch. An example
is:

https://github.com/apache/kafka/pull/98

I tried to fix it on my local machine as follows:

{code}
-    pr_title = pr["title"]
+    pr_title = pr["title"].encode("utf-8")
{code}

But it does not seem fix all the problems. Could you take a look?

> Override commit message title in kafka-merge-pr.py
> --------------------------------------------------
>
>                 Key: KAFKA-2384
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2384
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Guozhang Wang
>            Assignee: Ismael Juma
>             Fix For: 0.8.3
>
>
> It would be more convenient allow setting the commit message in the merging script; right
now the script takes the PR title as is and the contributors have to change them according
to the submission-review guidelines before doing the merge.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message