kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ismael Juma (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-2285) Logging trait obfuscates call site information
Date Mon, 03 Aug 2015 23:19:05 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-2285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652767#comment-14652767

Ismael Juma commented on KAFKA-2285:

Also see https://issues.apache.org/jira/plugins/servlet/mobile#issue/KAFKA-1351

> Logging trait obfuscates call site information
> ----------------------------------------------
>                 Key: KAFKA-2285
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2285
>             Project: Kafka
>          Issue Type: Improvement
>          Components: core
>    Affects Versions:
>            Reporter: E. Sammer
>            Assignee: Grant Henke
> Using a logging trait, as many components in the codebase do, destroys call site information
in logging message making debugging certain kinds of failures annoying in production systems.
Most messages end up look like:
> {code}
> 2015-06-18 07:41:11,550 (kafka-request-handler-0) [WARN - kafka.utils.Logging$class.warn(Logging.scala:83)]
Partition [events,1] on broker 1: No checkpointed highwatermark is found for partition [events,1]
> {code}
> I think the mental overhead of issuing the standard incantation of {{private static final
Logger logger = LoggerFactory.get(Foo.class)}} (or the even shorter Scala equivalent) for
each class is outweighed by the operational overhead of mapping strings back to their original
call sites. This is an easy win improve the traceability of complex failures in production

This message was sent by Atlassian JIRA

View raw message