kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Edward Ribeiro" <edward.ribe...@gmail.com>
Subject Re: Review Request 33125: Add comment to timing fix
Date Mon, 03 Aug 2015 19:41:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33125/#review93953
-----------------------------------------------------------



clients/src/test/java/org/apache/kafka/clients/MetadataTest.java (line 58)
<https://reviews.apache.org/r/33125/#comment148391>

    Wow, 1 millisecond?! Does it make a difference? Just curious. :)


- Edward Ribeiro


On April 13, 2015, 7:15 p.m., Rajini Sivaram wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33125/
> -----------------------------------------------------------
> 
> (Updated April 13, 2015, 7:15 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-2089
>     https://issues.apache.org/jira/browse/KAFKA-2089
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Patch for KAFKA-2089: Fix timing issue in MetadataTest
> 
> 
> Diffs
> -----
> 
>   clients/src/test/java/org/apache/kafka/clients/MetadataTest.java 928087d29deb80655ca83726c1ebc45d76468c1f

> 
> Diff: https://reviews.apache.org/r/33125/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajini Sivaram
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message