Return-Path: X-Original-To: apmail-kafka-dev-archive@www.apache.org Delivered-To: apmail-kafka-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 83C2817D8B for ; Fri, 3 Jul 2015 01:36:20 +0000 (UTC) Received: (qmail 73295 invoked by uid 500); 3 Jul 2015 01:36:15 -0000 Delivered-To: apmail-kafka-dev-archive@kafka.apache.org Received: (qmail 73192 invoked by uid 500); 3 Jul 2015 01:36:15 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 73179 invoked by uid 99); 3 Jul 2015 01:36:15 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Jul 2015 01:36:15 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id F0AB7AC561; Fri, 3 Jul 2015 01:36:13 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6182502256456963823==" MIME-Version: 1.0 Subject: Re: Review Request 36034: Patch for KAFKA-2306 From: "Guozhang Wang" To: "kafka" , "Guozhang Wang" , "Dong Lin" Date: Fri, 03 Jul 2015 01:36:13 -0000 Message-ID: <20150703013613.13307.71762@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Guozhang Wang" X-ReviewGroup: kafka X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/36034/ X-Sender: "Guozhang Wang" References: <20150630040418.13308.59278@reviews.apache.org> In-Reply-To: <20150630040418.13308.59278@reviews.apache.org> Reply-To: "Guozhang Wang" X-ReviewRequest-Repository: kafka --===============6182502256456963823== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36034/#review90303 ----------------------------------------------------------- Thanks for the patch. I have a few thoughts regarding the names of the metrics, since in the producer other causes can also result in dropped messages (i.e. rejected before it enteres the producer buffer), such as message-size-too-large, serialization-failed, etc. In the old producer since we only have one cause we named that to droppedMessageRate. So I think we could either: 1. record dropped messages for any KafkaExceptions, but not limited to BufferExhaustedException. 2. have a separate metric for buffer-exhausted with a different name. I prefer the first option since I feel in practice people just want to distinguish between the case that messages failed to get into the producer from the case the messages gets failed to send to the broker. - Guozhang Wang On June 30, 2015, 4:04 a.m., Dong Lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36034/ > ----------------------------------------------------------- > > (Updated June 30, 2015, 4:04 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2306 > https://issues.apache.org/jira/browse/KAFKA-2306 > > > Repository: kafka > > > Description > ------- > > KAFKA-2306; New producer should emit metrics for buffer exhaustion > > > Diffs > ----- > > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java 5671a3fbeea8cb9a9ffeeb41aa1b132b92c0cae8 > clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java 0baf16e55046a2f49f6431e01d52c323c95eddf0 > > Diff: https://reviews.apache.org/r/36034/diff/ > > > Testing > ------- > > > Thanks, > > Dong Lin > > --===============6182502256456963823==--