kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Manikumar Reddy O" <manikumar.re...@gmail.com>
Subject Re: Review Request 35880: Patch for KAFKA-2295
Date Mon, 06 Jul 2015 06:05:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35880/
-----------------------------------------------------------

(Updated July 6, 2015, 6:05 a.m.)


Review request for kafka.


Bugs: KAFKA-2295
    https://issues.apache.org/jira/browse/KAFKA-2295


Repository: kafka


Description (updated)
-------

Addessing Guozhang's comments


Diffs (updated)
-----

  clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java bae528d31516679bed88ee61b408f209f185a8cc

  clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java 4170bcc7def5b50d8aa20e8e84089c35b705b527

  clients/src/main/java/org/apache/kafka/common/utils/Utils.java af9993cf9b3991f1e61e1201c94e19bc1bf76a68

  clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java db1b0ee9113215b5ad7fda0f93915f3bdd34ac55

  core/src/main/scala/kafka/utils/CoreUtils.scala 168a18d380c200ee566eccb6988dd1ae85ed5b09


Diff: https://reviews.apache.org/r/35880/diff/


Testing
-------


Thanks,

Manikumar Reddy O


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message