kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ewen Cheslack-Postava" ...@ewencp.org>
Subject Re: Review Request 35850: Patch for KAFKA-2301
Date Thu, 02 Jul 2015 08:01:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35850/#review90199
-----------------------------------------------------------



core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala (line 110)
<https://reviews.apache.org/r/35850/#comment143205>

    Since this is a warning, can we just use warn() instead of info()? Otherwise, this trivial
patch LGTM!


- Ewen Cheslack-Postava


On July 2, 2015, 12:46 a.m., Ashish Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35850/
> -----------------------------------------------------------
> 
> (Updated July 2, 2015, 12:46 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-2301
>     https://issues.apache.org/jira/browse/KAFKA-2301
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-2301: Deprecate ConsumerOffsetChecker
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 3d52f62c88a509a655cf1df6232b738c25fa9b69

> 
> Diff: https://reviews.apache.org/r/35850/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ashish Singh
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message