Return-Path: X-Original-To: apmail-kafka-dev-archive@www.apache.org Delivered-To: apmail-kafka-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F252E11BBA for ; Thu, 17 Jul 2014 02:12:04 +0000 (UTC) Received: (qmail 98496 invoked by uid 500); 17 Jul 2014 02:12:04 -0000 Delivered-To: apmail-kafka-dev-archive@kafka.apache.org Received: (qmail 98448 invoked by uid 500); 17 Jul 2014 02:12:04 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 98436 invoked by uid 99); 17 Jul 2014 02:12:04 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Jul 2014 02:12:04 +0000 Date: Thu, 17 Jul 2014 02:12:04 +0000 (UTC) From: "BalajiSeshadri (JIRA)" To: dev@kafka.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KAFKA-328) Write unit test for kafka server startup and shutdown API MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KAFKA-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14064490#comment-14064490 ] BalajiSeshadri commented on KAFKA-328: -------------------------------------- Please assign to me i will work on the fix. > Write unit test for kafka server startup and shutdown API > ---------------------------------------------------------- > > Key: KAFKA-328 > URL: https://issues.apache.org/jira/browse/KAFKA-328 > Project: Kafka > Issue Type: Bug > Reporter: Neha Narkhede > Labels: newbie > > Background discussion in KAFKA-320 > People often try to embed KafkaServer in an application that ends up calling startup() and shutdown() repeatedly and sometimes in odd ways. To ensure this works correctly we have to be very careful about cleaning up resources. This is a good practice for making unit tests reliable anyway. > A good first step would be to add some unit tests on startup and shutdown to cover various cases: > 1. A Kafka server can startup if it is not already starting up, if it is not currently being shutdown, or if it hasn't been already started > 2. A Kafka server can shutdown if it is not already shutting down, if it is not currently starting up, or if it hasn't been already shutdown. -- This message was sent by Atlassian JIRA (v6.2#6252)