kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neha Narkhede" <neha.narkh...@gmail.com>
Subject Re: Review Request 15964: Patch for KAFKA-1156
Date Wed, 04 Dec 2013 00:22:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15964/
-----------------------------------------------------------

(Updated Dec. 4, 2013, 12:22 a.m.)


Review request for kafka.


Bugs: KAFKA-1156
    https://issues.apache.org/jira/browse/KAFKA-1156


Repository: kafka


Description (updated)
-------

Removed the option to output the entire cluster's current partition assignment, since it doesn't
seem very relevant to the generate option


Included Jun's review suggestions


Found and fixed a bug during partition reassignment if a partition is being reassigned to
the same set of replicas repeatedly


Improved the partition reassignment tool to - 1) Output the previous partition replica assignment
before kicking off the new assignment, to help with rollback 2) Have 3 options - generate,
verify, execute 3) Cleaned up tool to use the 3 options properly


Diffs (updated)
-----

  core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala 70d1b81f7dab2b3316af77738d682427d668be14

  core/src/main/scala/kafka/controller/KafkaController.scala 4c319aba97655e7c4ec97fac2e34de4e28c9f5d3


Diff: https://reviews.apache.org/r/15964/diff/


Testing
-------


Thanks,

Neha Narkhede


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message