kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neha Narkhede" <neha.narkh...@gmail.com>
Subject Re: Review Request 15953: Patch for KAFKA-1134
Date Tue, 03 Dec 2013 01:30:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15953/#review29636
-----------------------------------------------------------



core/src/main/scala/kafka/controller/KafkaController.scala
<https://reviews.apache.org/r/15953/#comment57045>

    it seems that onControllerFailover is already protected by the controllerLock. The elect()
API of ZookeeperLeaderElector is invoked in 3 places and each of those acquires the controllerLock


- Neha Narkhede


On Dec. 3, 2013, 12:58 a.m., Guozhang Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15953/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2013, 12:58 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1134
>     https://issues.apache.org/jira/browse/KAFKA-1134
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-1134.v1
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/controller/KafkaController.scala 4c319aba97655e7c4ec97fac2e34de4e28c9f5d3

> 
> Diff: https://reviews.apache.org/r/15953/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guozhang Wang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message