kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neha Narkhede" <neha.narkh...@gmail.com>
Subject Re: Review Request 15659: Incorporate Joel/Jun's comments, MM system test passed, rebased
Date Mon, 02 Dec 2013 17:24:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15659/#review29593
-----------------------------------------------------------



core/src/main/scala/kafka/consumer/ZookeeperTopicEventWatcher.scala
<https://reviews.apache.org/r/15659/#comment56989>

    Can we improve this WARN? It implies that we will not shutdown the client, but we proceed
with the shutdown anyways :)


- Neha Narkhede


On Nov. 21, 2013, 7:22 p.m., Guozhang Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15659/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2013, 7:22 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1103
>     https://issues.apache.org/jira/browse/KAFKA-1103
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-1103.v2
> 
> 
> Dummy
> 
> 
> KAFKA-1103.v1
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/consumer/TopicFilter.scala cf3853b223095e1fe0921175c407a906828b8113

>   core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 6d0cfa665e90a168a70501a81f10fa4d3c7a7f22

>   core/src/main/scala/kafka/consumer/ZookeeperTopicEventWatcher.scala a67c193df9f7cbfc52f75dc1b71dc017de1b5fe2

>   core/src/test/scala/unit/kafka/consumer/TopicFilterTest.scala 40a2bf7a9277eb5f94bc07b40d7726d81860cefc

>   system_test/migration_tool_testsuite/0.7/config/test-log4j.properties a3ae33f20e4b7cff87d8cf8368d0639b8bea73a6

> 
> Diff: https://reviews.apache.org/r/15659/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guozhang Wang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message