kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neha Narkhede" <neha.narkh...@gmail.com>
Subject Re: Review Request 15901: Patch for KAFKA-1152
Date Mon, 02 Dec 2013 17:06:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15901/#review29588
-----------------------------------------------------------



core/src/main/scala/kafka/server/ReplicaManager.scala
<https://reviews.apache.org/r/15901/#comment56984>

    the check should probably be leaderId >= 0. The "leaders" in the LeaderAndIsrRequest
is misleading, cannot be trusted and needs to be deprecated.



core/src/main/scala/kafka/server/ReplicaManager.scala
<https://reviews.apache.org/r/15901/#comment56983>

    this format statement is broken. We need a parentheses surrounding the entire trace statement


- Neha Narkhede


On Nov. 29, 2013, 6:41 a.m., Swapnil Ghike wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15901/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2013, 6:41 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1152
>     https://issues.apache.org/jira/browse/KAFKA-1152
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> ReplicaManager's handling of the leaderAndIsrRequest should gracefully handle leader
== -1
> 
> 
> ReplicaManager's handling of the leaderAndIsrRequest should gracefully handle leader
== -1
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/server/ReplicaManager.scala 161f58134f20f9335dbd2bee6ac3f71897cbef7c

> 
> Diff: https://reviews.apache.org/r/15901/diff/
> 
> 
> Testing
> -------
> 
> Builds with all scala versions; unit tests pass
> 
> 
> Thanks,
> 
> Swapnil Ghike
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message