kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guozhang Wang" <guw...@linkedin.com>
Subject Re: Review Request 15201: tool for checking the consistency among replicas
Date Tue, 05 Nov 2013 22:41:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15201/#review28162
-----------------------------------------------------------



core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala
<https://reviews.apache.org/r/15201/#comment54778>

    We do not need () after withRequiredArg here.



core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala
<https://reviews.apache.org/r/15201/#comment54780>

    Ditto as above for these three.



core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala
<https://reviews.apache.org/r/15201/#comment54785>

    Why do we ask for all topics from brokers then filter them? Is this because the start-up
brokers may not have metadata info for all the topics yet?



core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala
<https://reviews.apache.org/r/15201/#comment54945>

    In think in this case the verification would stop and probably report the max lag for
this topic-partition. This is also fine I think.



core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala
<https://reviews.apache.org/r/15201/#comment54865>

    createNewVerificationBarrier here will set the count to 1, and then count it down to 0.
So the next round the verification barrier count would be 1 and hence not holding other threads?


- Guozhang Wang


On Nov. 4, 2013, 12:34 a.m., Jun Rao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15201/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2013, 12:34 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1117
>     https://issues.apache.org/jira/browse/KAFKA-1117
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> kafka-1117
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/15201/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jun Rao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message