kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neha Narkhede" <neha.narkh...@gmail.com>
Subject Re: Review Request 15137: Patch for KAFKA-1107
Date Fri, 01 Nov 2013 04:29:17 GMT


> On Nov. 1, 2013, 1:03 a.m., Swapnil Ghike wrote:
> > core/src/test/scala/unit/kafka/log/LogTest.scala, line 631
> > <https://reviews.apache.org/r/15137/diff/5/?file=375364#file375364line631>
> >
> >     probably don't need this statement.

We need to define recoveryPoint as a var here, but you're right, we don't need to initialize
it to 50. Changed it to 0.


- Neha


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15137/#review27988
-----------------------------------------------------------


On Oct. 31, 2013, 10:28 p.m., Neha Narkhede wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15137/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2013, 10:28 p.m.)
> 
> 
> Review request for kafka and Jay Kreps.
> 
> 
> Bugs: KAFKA-1107
>     https://issues.apache.org/jira/browse/KAFKA-1107
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Remove whitespace changes to LogTest
> 
> 
> Removed an unncessary log statement and fixed a few more tests that initially had the
Log public API change
> 
> 
> Per Jay's suggestion, avoid changing the public API of Log
> 
> 
> Avoid printing clean shutdown file log message on every log
> 
> 
> KAFKA-1107 Broker unnecessarily recovers all logs when upgrading from 0.8 to 0.8.1; Fix
includes modifying Log to avoid recovery if the clean shutdown file exists; LogManager deletes
the clean shutdown file after all logs in a log directory have finished loading; If the clean
shutdown file does not exist, fall back to 0.8.1 recovery logic
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/log/Log.scala 0cc402b13e8484ae5569f1b8ff7156331a2f82d7 
>   core/src/main/scala/kafka/log/LogManager.scala d489e08452ab97334d504f76f381eb314ec56901

>   core/src/test/scala/unit/kafka/log/LogTest.scala 140317c6ab6741308d125e9c1f43078b672c5f95

> 
> Diff: https://reviews.apache.org/r/15137/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Neha Narkhede
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message