kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neha Narkhede (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-840) Controller tries to perform preferred replica election on failover before state machines have started up
Date Tue, 02 Apr 2013 16:31:17 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13619965#comment-13619965
] 

Neha Narkhede commented on KAFKA-840:
-------------------------------------

Thanks for the patch! One issue is that the !hasShutdown check should be within the lock,
otherwise the state machine can end up trying to respond to a zookeeper listener even after
it has shutdown. Today, this cannot happen since we close the zkclient before the controller
shuts down, but this is a defensive check which will protect us if the shutdown order changes
in the future.

                
> Controller tries to perform preferred replica election on failover before state machines
have started up
> --------------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-840
>                 URL: https://issues.apache.org/jira/browse/KAFKA-840
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.8
>            Reporter: Swapnil Ghike
>            Assignee: Swapnil Ghike
>            Priority: Blocker
>              Labels: bugs
>             Fix For: 0.8
>
>         Attachments: kafka-840-after-commit-v1.patch, kafka-840.patch, kafka-840-v2.patch
>
>
> If the admin/preferred_replica_election path is non-empty when a new controller starts,
the controller attempts to perform preferred replica election before the partition and replica
state machine have been initialized. In this case, the controller will try to make invalid
state transitions. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message