kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Swapnil Ghike (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (KAFKA-840) Controller tries to perform preferred replica election on failover before state machines have started up
Date Mon, 01 Apr 2013 21:19:17 GMT

     [ https://issues.apache.org/jira/browse/KAFKA-840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Swapnil Ghike updated KAFKA-840:
--------------------------------

    Attachment: kafka-840-after-commit-v1.patch

I made a mistake. Patch v2 ignores a broker/topic change listener callback if the state machines
have not started up. However, if such a callback occurs after the controller context has been
initialized in controller failover, the topic/broker change will not be noticed by the state
machines.

The right fix is to have to two separate flags in the state machines - hasStarted and hasShutdown.
                
> Controller tries to perform preferred replica election on failover before state machines
have started up
> --------------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-840
>                 URL: https://issues.apache.org/jira/browse/KAFKA-840
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.8
>            Reporter: Swapnil Ghike
>            Assignee: Swapnil Ghike
>            Priority: Blocker
>              Labels: bugs
>             Fix For: 0.8
>
>         Attachments: kafka-840-after-commit-v1.patch, kafka-840.patch, kafka-840-v2.patch
>
>
> If the admin/preferred_replica_election path is non-empty when a new controller starts,
the controller attempts to perform preferred replica election before the partition and replica
state machine have been initialized. In this case, the controller will try to make invalid
state transitions. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message