kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Swapnil Ghike (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x
Date Wed, 03 Apr 2013 00:07:16 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620428#comment-13620428
] 

Swapnil Ghike commented on KAFKA-826:
-------------------------------------

Dragos, thanks for the input. We can definitely use your patch if we decide to downgrade metrics
to 2.2.0. Could you please address the following comments and re-submit the patch?

1. Could you move the metrics-core, metrics-annotations and zkclient library dependences to
core/build.sbt? You will need to replace the old organization and version number of zkclient
there with the one you added to KafkaBuild.
2. Could you append the corresponding paths to class path in bin/kafka-run-class.sh? Also
please remove core/lib/*.jar from class path since we are moving the three jars there to ivy.
3. git rm core/lib for the same reason mentioned in 2.

Apart from your patch, we will need to fix the csv reporter separately.
                
> Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x
> -----------------------------------------------------
>
>                 Key: KAFKA-826
>                 URL: https://issues.apache.org/jira/browse/KAFKA-826
>             Project: Kafka
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 0.8
>            Reporter: Neha Narkhede
>            Assignee: Jun Rao
>            Priority: Blocker
>              Labels: build, kafka-0.8, metrics
>         Attachments: kafka-fix-for-826.patch, kafka-fix-for-826-take2.patch
>
>
> In order to mavenize Kafka 0.8, we have to depend on metrics 2.2.0 since metrics 3.x
is a huge change as well as not an officially supported release.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message